[DM-40192] Explicitly pass in S3 endpoint #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently with boto the automatic and using environment variables for the S3_ENDPOINT_URL only works and configures itself if you are using aws. Since for our case we're using our own S3, we need to pass it in when constructing the client. Also, fix an unneeded dependency on the test_links_errors_s3 test.
rra
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently with boto the automatic and using environment variables for the S3_ENDPOINT_URL only works and configures itself if you are using aws. Since for our case we're using our own S3, we need to pass it in when constructing the client.
Also, fix an unneeded dependency on the test_links_errors_s3 test.