TMA Implementation #352
Merged
TMA Implementation #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-aranda
requested changes
Feb 24, 2022
love/src/Config.js
Outdated
| 3: 'HHD', | ||
| }; | ||
|
|
||
| // TODO: Pending Style |
There was a problem hiding this comment.
This is still pending? If so, what is missing?
There was a problem hiding this comment.
Yes, need validation about the colors used for the states.
@MiaRoseElbo
| connected: summaryData['event-MTMount-0-connected'] | ||
| ? summaryData['event-MTMount-0-connected'][0].command.value | ||
| : false, | ||
| balancing: summaryData['event-MTMount-0-commander'] |
There was a problem hiding this comment.
Here should be event-MTMount-0-balanceSystemState instead of event-MTMount-0-commander
| flex-direction: column; | ||
| padding: 1em; | ||
| border-radius: 5px; | ||
| /* background: #132631; svg color, slightly better contrast with background */ |
Comment on lines
94
to
95
| const equivalentAzimuthActual = this.closestEquivalentAngle(this.prevAzimuthActual, this.props.azimuthActualPosition); | ||
| const equivalentAzimuthDemand = this.closestEquivalentAngle(this.prevAzimuthDemand, this.props.azimuthDemandPosition); |
There was a problem hiding this comment.
And here you should call this.state.prevAzimuthActual and this.state.prevAzimuthDemand
|
|
||
| export default class MirrorCovers extends Component { | ||
| static propTypes = { | ||
| /** Mirror Covers view width */ |
areyesd14
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
If all Sebastian comments were resolved, I approve this PR. Excellent job @fdelcampo !!
sebastian-aranda
force-pushed
the
tickets/LOVE-89
branch
from
4d48d46
to
9be36b0
Compare
…Summary component
…er with degree in variable. Pending evaluation of cases
…tate with different of angles for the difference states
sebastian-aranda
force-pushed
the
tickets/LOVE-89
branch
from
9be36b0
to
8c80fb8
Compare
sebastian-aranda
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Everything looks good and ready for merge! Great job @fdelcampo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains TMA Implementation.