Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GIS implementation #384

Merged
merged 41 commits into from
Oct 5, 2022
Merged

GIS implementation #384

merged 41 commits into from
Oct 5, 2022

Conversation

areyesd14
Copy link
Contributor

This PR contains GIS implementation

@sebastian-aranda sebastian-aranda changed the title WIP: GIS implementation GIS implementation Aug 24, 2022
areyesd14 and others added 28 commits October 5, 2022 17:44
@areyesd14 @sebastian-aranda
Initial commit
0c6b6d5
@areyesd14 @sebastian-aranda
Add initial object
7f789f2
@areyesd14 @sebastian-aranda
First approach
aff03d6
@areyesd14 @sebastian-aranda
Dictionary with signals and effects was added (only for testing)
b2056eb
@areyesd14 @sebastian-aranda
onHover effect was added
aa0ece9
@areyesd14 @sebastian-aranda
Signals were mapped
8251101
@areyesd14 @sebastian-aranda
small changes
6da7de1
@areyesd14 @sebastian-aranda
Subcomponent for signals and effects details was added
63ae09e
@areyesd14 @sebastian-aranda
Attempt to modularize the components
b9e63ff
@areyesd14 @sebastian-aranda
Second attempt to separate components
fc99c62
@areyesd14 @sebastian-aranda
Subcomponents separated but without css effects
371d42e
@areyesd14 @sebastian-aranda
Css was improved and more logic was added
e601687
@sebastian-aranda
Adjust flex childs
a3c30b5
@sebastian-aranda
Improving display
bd69928
@areyesd14 @sebastian-aranda
Alert color and their logic were added
cba9582
@areyesd14 @sebastian-aranda
Some variable names were changed
0e824d8
@sebastian-aranda
Minor CSS adjustments
7ed2df3
@areyesd14 @sebastian-aranda
Minor changes on css
f2de654
@sebastian-aranda
Minor color adjustments
f5d6e3e
@sebastian-aranda
Fix hovering border issue
789c130
@sebastian-aranda
Add alert border to system if signal or effect is triggered
5734e56
@sebastian-aranda
Minor css fixes
a848442
@areyesd14 @sebastian-aranda
SignalIndexes maps was created and new logic to know which signal is on
bff4131
@areyesd14 @sebastian-aranda
Event for GIS was added
8cd0060
@areyesd14 @sebastian-aranda
Refactor code and other changes
1995ea1
@areyesd14 @sebastian-aranda
Bypass dict was added and other changes
b095bbd
@areyesd14 @sebastian-aranda
Unused code was removed and logic to include bypass dict was added
df9f524
@areyesd14 @sebastian-aranda
PropTypes and defaultProps were added and unused code was removed
04f01d6
sebastian-aranda
sebastian-aranda approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@sebastian-aranda sebastian-aranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thanks @areyesd14 !

@areyesd14 areyesd14 merged commit 9c99568 into develop Oct 5, 2022
@sebastian-aranda sebastian-aranda deleted the tickets/LOVE-110 branch October 7, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-aranda sebastian-aranda sebastian-aranda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@areyesd14 @sebastian-aranda