LOVE EFD Status in Dropdown menu Navbar #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-aranda
requested changes
Sep 14, 2022
love/src/Utils.js
Outdated
| @@ -308,6 +308,23 @@ export default class ManagerInterface { | |||
| }); | |||
| } | |||
|
|
|||
| static getEDFStatus() { | |||
| const url = `https://summit-lsp.lsst.codes/influxdb/health`; | |||
There was a problem hiding this comment.
This should not be fixed. We can use the LOVE configuration file to set this.
| @@ -32,6 +33,8 @@ import EmergencyContactsPanel from './EmergencyContactsPanel/EmergencyContactsPa | |||
| import UserDetails from './UserDetails/UserDetails'; | |||
| import UserSwapContainer from '../Login/UserSwap.container'; | |||
| import { severityEnum } from '../../Config'; | |||
| import ManagerInterface from 'Utils'; | |||
| import { style } from 'd3'; | |||
There was a problem hiding this comment.
I think d3 is not being used.
…. Fix utils with parameter url and the container with selector with state
sebastian-aranda
requested changes
Sep 15, 2022
sebastian-aranda
requested changes
Sep 15, 2022
| @@ -238,6 +241,16 @@ class Layout extends Component { | |||
| }); | |||
| }; | |||
|
|
|||
| checkEfdStatus = () => { | |||
| const url = this.props.efdConfigFile.urlStatus; | |||
There was a problem hiding this comment.
I think this is missing a validation. What happens if the urlStatus is not present? It doesn't throw any error?
… with timeout and add catch case when it's exceded timeout
sebastian-aranda
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add request to the status of EFD with Heartbeat. Show in the Navbar