Improved Az and El display for ATDome MTDome and TMA #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| render() { | ||
| const { className, height, width, currentValue, targetValue, radius, valueOrigin, displayLabels } = this.props; | ||
|
|
||
| //const {currentValue, targetValue} = this.state; |
There was a problem hiding this comment.
this line should be removed
|
|
||
| > | ||
|
|
||
| {/* Ritate Center */} |
There was a problem hiding this comment.
this should be Rotate
| className={styles.targetText} | ||
| > | ||
| <text | ||
| //transform={`${"translate("+currentText_X+" "+currentText_Y+")"}`} |
There was a problem hiding this comment.
this line should be removed
Comment on lines
45
to
56
| setInterval(() => { | ||
| const randomValue = Math.ceil(Math.random()*360) | ||
|
|
||
| this.setState((prevState) => ({ | ||
| ...prevState,targetValue: randomValue | ||
| })) | ||
|
|
||
| setTimeout(() => console.log(this.setState((prevState) => ({ | ||
| ...prevState,currentValue: randomValue | ||
| }))), 2500); | ||
|
|
||
| }, 5000); |
There was a problem hiding this comment.
I think these lines should be removed as they are only setting random values
Comment on lines
61
to
72
| setInterval(() => { | ||
| const randomValue = Math.ceil(Math.random()*130-20) | ||
|
|
||
| this.setState((prevState) => ({ | ||
| ...prevState,targetValue: randomValue | ||
| })) | ||
|
|
||
| setTimeout(() => console.log(this.setState((prevState) => ({ | ||
| ...prevState,currentValue: randomValue | ||
| }))), 2500); | ||
|
|
||
| }, 5000); |
There was a problem hiding this comment.
As explained above, this should be removed too
| transform={`${"rotate("+(currentValue*-1)+")"}`} | ||
| > | ||
| <text | ||
| //transform={`${"translate("+currentText_X+" "+currentText_Y+")"}`} |
There was a problem hiding this comment.
this line should be removed
Comment on lines
65
to
76
| setInterval(() => { | ||
| const randomValue = Math.ceil((Math.random()*((2*270))-270)) | ||
|
|
||
| this.setState((prevState) => ({ | ||
| ...prevState,targetValue: randomValue | ||
| })) | ||
|
|
||
| setTimeout(() => console.log(this.setState((prevState) => ({ | ||
| ...prevState,currentValue: randomValue | ||
| }))), 2500); | ||
|
|
||
| }, 5000); |
There was a problem hiding this comment.
As explained above these lines should be removed too
| render() { | ||
| const {currentValue, targetValue, height, maxL3, maxL2, maxL1, minL1, minL2, minL3, radius, rotationOffset, displayLabels } = this.props; | ||
|
|
||
| //const {currentValue, targetValue} = this.state; |
There was a problem hiding this comment.
this line should be removed
sebastian-aranda
requested changes
Dec 12, 2022
There was a problem hiding this comment.
Really nice job @MiaRoseElbo 👏. I've left a few minor comments.
sebastian-aranda
approved these changes
Dec 20, 2022
sebastian-aranda
force-pushed
the
tickets/LOVE-126
branch
from
b6d6759
to
39d8ebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains improvements for Az and EL displays for ATDome, MTDome and TMA.
Created a new Elevation and Azimuth General Purpose components instanced in both the AT and MT Dome components and in the TMA component.
Created a unique Az display for the TMA.