Tickets/love 89 Mirror Cover Status in TMA #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-aranda
requested changes
Apr 3, 2023
There was a problem hiding this comment.
Great job @fdelcampo ! I've only left a few comments regarding not removed comment blocks. Please take a look to them. Thanks!
Comment on lines
65
to
70
| {/* {<div className={styles.azContainer}> | ||
| <Azimuth | ||
| currentValue={this.props.azimuthActualPosition} | ||
| targetValue={this.props.azimuthDemandPosition} | ||
| /> | ||
| </div>} */} |
There was a problem hiding this comment.
This comment block should be removed.
Comment on lines
76
to
87
| // getAngleClosedCoverMirror() { | ||
| // const stateToClosedMTMountMirrorCoversState = { | ||
| // RETRACTED: Math.PI / 12, | ||
| // DEPLOYED: Math.PI / 2 + Math.PI / 4, | ||
| // RETRACTING: Math.PI / 2, | ||
| // DEPLOYING: Math.PI / 2 - Math.PI / 6, | ||
| // LOST: -Math.PI / 36, | ||
| // }; | ||
| // // const mirrorCoversValue = this.props.mirrorCoversState.map((state) => mtMountMirrorCoversStateMap[state]); | ||
| // // return mirrorCoversValue.map((value) => stateToClosedMTMountMirrorCoversState[value]); | ||
| // return this.props.mirrorCoversPosition.map((value) => value + 5); | ||
| // } |
There was a problem hiding this comment.
This comment block should be removed.
| // const mirrorCoversValue = this.props.mirrorCoversState.map((state) => mtMountMirrorCoversStateMap[state]); | ||
| // return mirrorCoversValue.map((value) => stateToClosedMTMountMirrorCoversState[value]); | ||
| //} | ||
|
|
There was a problem hiding this comment.
This comment block should be removed.
Comment on lines
+141
to
+111
| //'ok': styles.ok, | ||
| //'warning': styles.warning, |
There was a problem hiding this comment.
These lines should be removed.
Comment on lines
23
to
29
| /* .azContainer { | ||
| position: absolute; | ||
| left: -60%; | ||
| top: -60%; | ||
| width: 220%; | ||
| } | ||
| /* width: 100%; * | ||
| } */ |
There was a problem hiding this comment.
This comment block should be removed.
Comment on lines
189
to
193
| /* .bgCurrent { | ||
| fill: transparent; | ||
| stroke: #3a525f60; | ||
| transition: stroke-dasharray linear 0.5s; | ||
| } */ |
There was a problem hiding this comment.
This comment block should be removed.
sebastian-aranda
approved these changes
Apr 3, 2023
…down (angles with both position the rotations)
… to MirrorCovers component
fdelcampo
force-pushed
the
tickets/LOVE-89
branch
from
b145f6e
to
aade7a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added telemetries about the individual status of the mirror covers, and add the individual position.
Refactor about azimuth visualization in this component