Add Aircraft Tracker component implementation #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zooming, show it name
…he ID of airplane near of the airplane draw in the map.
fdelcampo
force-pushed
the
tickets/LOVE-169
branch
from
ea1178a
to
c688da8
Compare
sebastian-aranda
requested changes
Apr 12, 2023
There was a problem hiding this comment.
I've left several comments, please take a look to them @fdelcampo. Thanks!
Comment on lines
41
to
45
| const data = getFlightTracker(state); | ||
| return { | ||
| status: data.status, | ||
| aircrafts: data.aircrafts, | ||
| } |
There was a problem hiding this comment.
Suggestion: this could be:
const data = getFlightTracker(state);
return data;And would yield the same result.
There was a problem hiding this comment.
Now try with return { ...data };
sebastian-aranda
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
I still suggest checking this comment: https://github.com/lsst-ts/LOVE-frontend/pull/447/files#r1164671409, although it is not urgent. I've also requested to change PR title name and also set your addition on the CHANGELOG to be the PR title @fdelcampo 🙏️
fdelcampo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.