Improve ScriptQueue search scripts functionality #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et filter, show the filtered scripts otherwise
…mounted Improve rendering behavior Add PropTypes
sebastian-aranda
force-pushed
the
tickets/DM-40260
branch
from
6704016
to
4d16a9d
Compare
areyesd14
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make some changes to improve the search functionality of scripts on the
ScriptQueue.jsxcomponent. After the latest upgrades, the search functionality was not adjusted to consider the new tree structured list of scripts. Now when using the search bar the list of scripts won't display the hierarchy and only the scripts that matches the search, this will help the UX when using the filter. Also rendering improvement was done and proptypes were added.