OLE layout improvements #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-aranda
force-pushed
the
tickets/DM-40318
branch
from
f09adb1
to
f2d7093
Compare
areyesd14
reviewed
Aug 14, 2023
| toggleTemperature: (show) => { console.log('Selector.defaultProps.toggleTemperature(', show, ')')}, | ||
| toggleWarnings: (show) => { console.log('Selector.defaultProps.toggleWarnings(', show, ')')}, | ||
| toggleFcuIDs: (show) => { | ||
| console.log('Selector.defaultProps.toggleFcuIDs(', show, ')'); |
There was a problem hiding this comment.
Should these console.log be removed?
areyesd14
reviewed
Aug 14, 2023
| fill: var(--secondary-font-color); | ||
| } | ||
|
|
||
| /* .icon .path { |
There was a problem hiding this comment.
Should these commented lines be removed?
areyesd14
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Looks good. Thanks @sebastian-aranda !!
I left some comments to review 😉
sebastian-aranda
force-pushed
the
tickets/DM-40318
branch
2 times, most recently
from
4576a75
to
bc09da0
Compare
…itle input Also some code cleaning
sebastian-aranda
force-pushed
the
tickets/DM-40318
branch
from
bc09da0
to
2366235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several improvements: