ESS implementation #506
Merged
ESS implementation #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaRoseElbo
reviewed
Sep 13, 2023
| import Value from 'components/GeneralPurpose/SummaryPanel/Value'; | ||
| import StatusText from 'components/GeneralPurpose/StatusText/StatusText'; | ||
| import { fixedFloat } from 'Utils'; | ||
| import styles from './Info.module.css'; |
There was a problem hiding this comment.
Maybe we should get rid of Info.module.css since it's not really being used.
MiaRoseElbo
reviewed
Sep 13, 2023
MiaRoseElbo
approved these changes
Sep 13, 2023
| @@ -1071,7 +1071,7 @@ export const getLouversStatus = (state) => { | |||
| return { | |||
| actualPositionLouvers: louvers['telemetry-MTDome-0-louvers'] | |||
| ? louvers['telemetry-MTDome-0-louvers'].positionActual.value | |||
| : [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], | |||
| : [50, 30, 70, 90, 100, 20, 50, 50, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], | |||
There was a problem hiding this comment.
Set default position back to 0
There was a problem hiding this comment.
Will this break WeatherStation / GlycolLoop / or other plots?
There was a problem hiding this comment.
Not, resolve the bug in all the location when used plot with resize observer
love/yarn.lock
Outdated
There was a problem hiding this comment.
Has this been rebased? versioning seems to be pushed up and there might be some conflicts with locked library versions.
…he main telescope
…sor in the right column
…nd max temperature limit for props configurate
…for the plotted and attributes of the selected sensor
…idity, airflow and temperature
…c in container of ESS component
…ction of speed vector in AirFlow and AirTurbulence
…pen when not received info from telemetry from telemetry-MTDome-0-louvers
…vector and add comparator function for the render only when its changed an attribute
…ation. Add the azimuth position to the rotation of the main door and dropout door and the percent open from the telemetries
…nnect in componentWillUnmount of the plot component
… windows of the auxtel
fdelcampo
force-pushed
the
tickets/LOVE-201
branch
from
93482c8
to
fb138e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.