Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Plot component #525

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Improvements for Plot component #525

merged 6 commits into from
Sep 22, 2023

Conversation

sebastian-aranda
Copy link
Contributor

This PR makes several adjustments to improve the Plot component code and behavior. The following was done:

  • Avoid excesive backend queries, now just 1 one is done when the component mounts.
  • The Slider component was fixed.
  • A new DualSlider component was added for future implementations.
  • Cleaned Plot and PlotContainer base code to make it a bit more readable.
  • Fixed plots ref assignments and added code comments to avoid confusions.

Copy link
Contributor

@couger01 couger01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sebastian-aranda sebastian-aranda force-pushed the tickets/DM-40667 branch 2 times, most recently from 21a1a48 to e1ee625 Compare September 22, 2023 20:02
Copy link
Contributor

@MiaRoseElbo MiaRoseElbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@sebastian-aranda sebastian-aranda merged commit 05e7419 into develop Sep 22, 2023
1 check passed
@sebastian-aranda sebastian-aranda deleted the tickets/DM-40667 branch September 22, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants