Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend OLE Jira feature by implementing a compatible wysiwyg #543

Merged
merged 9 commits into from
Oct 20, 2023

Conversation

sebastian-aranda
Copy link
Contributor

@sebastian-aranda sebastian-aranda commented Oct 17, 2023

This PR adds a new component: RichTextEditor which is isued to implement a rich text editor of preference. In this case we are using: react-quill for simplicity of implementation, which outputs its content in HTML format.
As this is implemented for the OLE, the message must be in jira wikimarkup format: https://jira.atlassian.com/secure/WikiRendererHelpAction.jspa?section=all, so a couple utility functions where created for parsing from HTML <-> jira wikimarkup. Although only basic formatting will be allowed for the moment: links and headings.

Copy link

@wvreeven wvreeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please see my comment.

return `{code}${p1}{code}`;
});

// TODO: Parse lists

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In TSSW all TODOs require a DM ticket. Please create one and add the ticket ID here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new learning for the day 💪. Thanks @wvreeven ! I've seen TODOs referencing DM tickets before, but didn't know it was a standard. I'll make the change 👍.

@sebastian-aranda sebastian-aranda merged commit 7b2ef5c into develop Oct 20, 2023
2 checks passed
@sebastian-aranda sebastian-aranda deleted the tickets/DM-41155 branch October 20, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants