-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend OLE Jira feature by implementing a compatible wysiwyg #543
Conversation
36c47ad
to
cdebf4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please see my comment.
love/src/Utils.js
Outdated
return `{code}${p1}{code}`; | ||
}); | ||
|
||
// TODO: Parse lists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In TSSW all TODOs require a DM ticket. Please create one and add the ticket ID here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new learning for the day 💪. Thanks @wvreeven ! I've seen TODOs referencing DM tickets before, but didn't know it was a standard. I'll make the change 👍.
2f54fa7
to
5c3f56b
Compare
This PR adds a new component:
RichTextEditor
which is isued to implement a rich text editor of preference. In this case we are using:react-quill
for simplicity of implementation, which outputs its content in HTML format.As this is implemented for the OLE, the message must be in jira wikimarkup format: https://jira.atlassian.com/secure/WikiRendererHelpAction.jspa?section=all, so a couple utility functions where created for parsing from HTML <-> jira wikimarkup. Although only basic formatting will be allowed for the moment: links and headings.