Adjust parameters names for ESS topics #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Item suffix to topic items
sebastian-aranda
force-pushed
the
tickets/DM-41266
branch
from
af821bd
to
b3353ce
Compare
MiaRoseElbo
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Everything looks ok, thanks for the update @sebastian-aranda !
sebastian-aranda
force-pushed
the
tickets/DM-41266
branch
from
b3353ce
to
ea50ebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts some ESS topics due to changes on the ESS XML that added the
Itemsuffix to some topic parameters. The parameters adjusted are:Also a recently added param,
airTemp, was removed as it was duplicating the current temperature value being displayed.