Add jira tickets auto conversion #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-aranda
force-pushed
the
tickets/DM-41184
branch
from
8440276
to
e41169d
Compare
wvreeven
approved these changes
Oct 30, 2023
love/src/Utils.js
Outdated
| @@ -1853,6 +1853,8 @@ export function trimString(string, length = 100) { | |||
| /** | |||
| * Function to parse HTML, generated by react-quill, to Jira Markdown. | |||
| * Check https://jira.atlassian.com/secure/WikiRendererHelpAction.jspa?section=all for more info | |||
| * This function also parse Jira tickets names that are not hyperlinks. | |||
| * Allowed projects are in AUTO_HYPERLINK_JIRA_PROJECTS. | |||
| * @param {string} html html to be parsed | |||
There was a problem hiding this comment.
Not related to your PR, but it the double html here correct?
There was a problem hiding this comment.
hey @wvreeven, thanks and good catch! So the first html is the name of the variable itself, although I will adjust the description for better readability. Here are some examples from the oficial docs: https://jsdoc.app/tags-param.html.
There was a problem hiding this comment.
Thanks for the explanation. Perhaps place a hyphen - between both, as suggested by the docs link, so it is clear which is the variable name and where the description starts?
| const expectedOutput = | ||
| 'This is a string with mixed content\r\nh1. This is a heading.\r\nThis is an already formatted link [DM-41184|https://jira.lsstcorp.org/browse/DM-41184].\r\nThis is a ticket name not yet formatted [DM-41184|https://jira.lsstcorp.org/browse/DM-41184].\r\n'; | ||
| expect(htmlToJiraMarkdown(input)).toEqual(expectedOutput); | ||
| }); |
There was a problem hiding this comment.
Consider adding a third test case, where
[DM-41184|https://jira.lsstcorp.org/browse/DM-41184]
is already present to make sure that it remains formatted correctly.
sebastian-aranda
force-pushed
the
tickets/DM-41184
branch
from
dec8712
to
91ad75b
Compare
…s to links Also made `jiraMarkdownToHtml` hyperlinks parsing more robuts
Also update package.json
sebastian-aranda
force-pushed
the
tickets/DM-41184
branch
from
91ad75b
to
58d2426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
htmlToJiraMarkdownfunction to support auto conversion of jira tickets to hyperlinks, e.g. DM-41184 -> DM-41184.