Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumb libs and update use of d3.event on several Components #558

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

MiaRoseElbo
Copy link
Contributor

This PR bumps the following libs in order to resolve some dependabot alerts:

  • "d3": "^7.8.5"
  • "d3-geo-voronoi": "^2.0.1"

It also removes:

  • cypress
  • vega-lib

And adds:

  • "moment": "^2.29.4",

This addition is done because Cybress used to import moment.

The version change from d3 5 to 6 includes a series of import changes, specifically the way d3.event is called. This means that a series of components using d3.event needed an update of their functions in order to work properly.

Copy link
Contributor

@areyesd14 areyesd14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @MiaRoseElbo !!

Copy link
Contributor

@sebastian-aranda sebastian-aranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too! Thanks @MiaRoseElbo.

@MiaRoseElbo MiaRoseElbo merged commit 739223e into develop Nov 2, 2023
3 checks passed
@MiaRoseElbo MiaRoseElbo deleted the tickets/LOVE-124 branch November 2, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants