Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CameraCableWrap UI swapped limits and floating points #628

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

sebastian-aranda
Copy link
Contributor

@sebastian-aranda sebastian-aranda commented Apr 3, 2024

This PR makes a couple fixes on the CameraCableWrap component. First, the floating points were fixed to 4, but if the received value was an integer, floating points were dismissed, this generated a visual difference when comparing both values (check LOVE-328). Also both limits of the component were swapped, so they were adjusted.

Copy link
Contributor

@couger01 couger01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sebastian-aranda sebastian-aranda merged commit eed7028 into develop Apr 4, 2024
2 checks passed
@sebastian-aranda sebastian-aranda deleted the tickets/DM-43669 branch April 4, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants