Fix observers dropdown on the NightReport component #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-aranda
force-pushed
the
tickets/DM-45352
branch
from
fad3c82
to
2a148f2
Compare
couger01
approved these changes
Jul 23, 2024
| function ObserversField({ isEditDisabled, observersFieldRef, userOptions, selectedUsers, setSelectedUsers }) { | ||
| function ObserversField({ isEditDisabled, userOptions, selectedUsers, setSelectedUsers }) { | ||
| const memoizedSelectedValueDecorator = useCallback( | ||
| (v) => (v.length > MULTI_SELECT_OPTION_LENGHT ? `...${v.slice(-MULTI_SELECT_OPTION_LENGHT)}` : v), |
There was a problem hiding this comment.
Length has a typo here. Might be good to fix for better maintenance.
There was a problem hiding this comment.
thanks for catching that! I'll make the change 👍.
… prevent unexpected renders on the users dropdown
…used in the `NightReport` component
sebastian-aranda
force-pushed
the
tickets/DM-45352
branch
from
2a148f2
to
6ab3668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some memoization to properties used by the
MultiSelectcomponent on theNightReportcomponent. As theNightReporthas an interval that re-renders it for triggering alerts in case some time have passed, theMultiSelectcomponent was being also re-rendered leading to unexpected behaviors as trying to select users and the dropdown being closed suddenly. By memoizing props we ensure theMultiSelectdoesn't get re-rendered on parent renders.