Error when trying to delete a view that hasn't a thumbnail uploaded #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areyesd14
approved these changes
Oct 26, 2021
…. In other cases serializer folder of media with the name of file
sebastian-aranda
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Great job @fdelcampo, thanks! I left two minor comments, the rest looks great
| @@ -76,10 +76,9 @@ class View(BaseModel): | |||
| data = JSONField(null=True, blank=True) | |||
| """The data that constitutes the View, stored as a JSON""" | |||
|
|
|||
| """ default="thumbnails/default.png", """ | |||
There was a problem hiding this comment.
I think this line should be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only remove the file thumbnail, when it's defined