Fix issue with update_time_lost being called on jira tickets that doesn't have a time lost defined #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes updates to the
update_time_lost
functionality and adds a new test case to ensure proper handling when thetime_lost
field isNone
for jira tickets that have not set that field.Updates to
update_time_lost
functionality:manager/manager/utils.py
: Modified theupdate_time_lost
function to handle cases where thetime_lost
field isNone
by checking the value before converting it to a float.New test case:
manager/api/tests/test_jira.py
: Added a new testtest_update_current_time_lost_none
to verify that theupdate_time_lost
function correctly updates thetime_lost
field when it is initiallyNone
.