Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API should return None from an bad object, not fail for the whole list #224

Open
RoyWilliams opened this issue Apr 10, 2024 · 1 comment
Open

API should return None from an bad object, not fail for the whole list #224

RoyWilliams opened this issue Apr 10, 2024 · 1 comment
Assignees
@RoyWilliams

Comments

@RoyWilliams
Copy link
Contributor

See here
https://community.lsst.org/t/l-sherlock-objects-skips-all-data-if-it-doesnt-find-one/8387/3
@RoyWilliams RoyWilliams self-assigned this Apr 10, 2024
@RoyWilliams
Copy link
Contributor Author

  • There should be a limit on the number of objectIds in the list sent to the API for the lightcurves, objects, sherlock_objects, and sherlock_positions methods.
  • The limit should be in the settings file
  • Error return should be 404 for objectIds that don't exist, and should include a message saying which objectIds have failed to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RoyWilliams RoyWilliams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RoyWilliams