Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sherlock wrapper cache needs a process for invalidating old entries #35

Open
gpfrancis opened this issue May 10, 2021 · 7 comments
Open
Assignees

Comments

@gpfrancis
Copy link
Member

No description provided.

@tms-epcc
Copy link
Contributor

14/JUL/21

  • @gpfrancis explained this is currently blocked by a Sherlock issue

@thespacedoctor
Copy link
Member

Hi @gpfrancis - I'm not sure what is being asked for here? Is this something I need to deal with?

@gpfrancis
Copy link
Member Author

@thespacedoctor - The issue here is that we should not annotate alerts with cached information that is out of date because a new version of Sherlock/catalogue/crossmatch algorithm is now available. Unfortuntaely, the only information that we have available at present is when Sherlock was run and what version. With this we could use a TTL on the cache, but that is inefficient and/or slow to update, or we could use the Sherlock version and hope that nothing else is ever changed without bumping the version number as well. I spoke to @genghisken about this and he told me that there is a wider issue around this with regard to recording prevenance that is already being looked at and hopefully that will give us a solution to this problem as well. Given this we decided to wait on the outcome of that discussion before doing anything else about this.

As far as I know you don't need to do anything new that you're not already doing.

@thespacedoctor
Copy link
Member

As of v2.2.0 Sherlock algorithm now ships alongside the code (and is therefore version controlled)

@tms-epcc
Copy link
Contributor

tms-epcc commented Oct 6, 2021

As discussed with @gpfrancis via email this is not a priority in Lasair cycle 5 and hence is moved into the backlog.

@gpfrancis gpfrancis transferred this issue from lsst-uk/ARCHIVE-lasair-lsst Aug 25, 2022
@thespacedoctor
Copy link
Member

I think this can be closed. Please reopen if I'm wrong @gpfrancis

@gpfrancis
Copy link
Member Author

We paused work on this because it wasn't high priority, but we neither completed it nor AFAIK made a decision to abandon it. The Sherlock issue referenced - which is now fixed - was something that this depended on, but is not actually the same issue.

@gpfrancis gpfrancis reopened this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants