Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-c 0.10.4 is not buildable on Rust 1.78 & 1.79 #407

Closed
AJIOB opened this issue Sep 11, 2024 · 6 comments
Closed

cargo-c 0.10.4 is not buildable on Rust 1.78 & 1.79 #407

AJIOB opened this issue Sep 11, 2024 · 6 comments

Comments

@AJIOB
Copy link

AJIOB commented Sep 11, 2024

orion-rs published their version 0.17.7 with MSRV 1.80 & it breaks clean builds.

Please, provide the Cargo.lock file for building on MSRV of your project (aka 1.78).

P.S. Looks like lots of previous releases cannot be built too

@lu-zero
Copy link
Owner

lu-zero commented Sep 11, 2024

if you use cargo install --locked it does not work?

@lu-zero
Copy link
Owner

lu-zero commented Sep 11, 2024

Also this project is not related at all with orion-rs since they do not seem to provide a C-ABI. I guess github glitched.

@lu-zero lu-zero closed this as completed Sep 11, 2024
@AJIOB
Copy link
Author

AJIOB commented Sep 11, 2024

This project indirectly depends on orion-rs.
As you know, Rust builds all the dependencies locally.

I've tested in the clear local docker environment, it's not a GitHub bug.

For calling cargo install --locked your repository must provide Cargo.lock file. For now, it doesn't do it. And I suggestes you to do it.

Please, try to call cargo install cargo-c inside the clear rust:1.78 docker/podman image. You will see that's I'm talking about.

@lu-zero
Copy link
Owner

lu-zero commented Sep 11, 2024

Ok, now I see the problems

@lu-zero lu-zero reopened this Sep 11, 2024
@lu-zero
Copy link
Owner

lu-zero commented Sep 11, 2024

there are 2 issues:

  • I did not bump the msrv to match cargo (my fault), I'll publish this weekend a version with it fixed.
  • orion-rs bumped their mrsv, but since I did not bump the msrv using --locked you still see problems

In general I suggest to use the cargo-c matching the cargo version in use, so

cargo +1.78 install cargo-c@0.10.2 --locked

Does solve your problem.

@lu-zero lu-zero changed the title Project is not buildable on Rust 1.78 & 1.79 cargo-c 0.10.4 is not buildable on Rust 1.78 & 1.79 Sep 11, 2024
@AJIOB
Copy link
Author

AJIOB commented Oct 9, 2024

Closed, becase we resolved it with private fork & Cargo.lock file

@AJIOB AJIOB closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants