Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activation: split Unix socket type into UnixStream and UnixDgram #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

activation: split Unix socket type into UnixStream and UnixDgram #56

wants to merge 1 commit into from

Conversation

jabedude
Copy link
Contributor

Closes #55.

@jabedude jabedude force-pushed the unix-sock branch 2 times, most recently from 3404920 to 39c8130 Compare July 25, 2020 03:44
lucab
lucab reviewed Jul 25, 2020
View reviewed changes
src/activation.rs Outdated Show resolved Hide resolved
src/activation.rs Show resolved Hide resolved
@jabedude
Copy link
Contributor Author

Hmm, this code is currently panicking my daemon. I used libc::getsockopt directly and it works. The nix code makes heavy use of macros and is a little hard for me to follow

@lucab
Copy link
Owner

lucab commented Jul 26, 2020

@jabedude let me know when you get to the bottom of your panics. Are those perhaps happening on invalid (e.g. closed in the meanwhile) FDs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucab lucab lucab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

activation::SocketFd needs to differentiate between UnixStream and UnixDgram types
2 participants
@jabedude @lucab