-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support any container registry #4
Comments
Thanks for the suggestion @mkumatag ! I'll take a look later to see what needs to be done to support this. |
I'm interested in using this action with private images on ghcr. Subscribed! 🥳 |
@twiddler I have just tried implementing the missing feature here - https://github.com/mkumatag/container-image-updater-action, can see if that works for you? |
@mkumatag Well that was fast. 😮 I checked your project but I didn't see how to provide the registry where to look up the file. My images are in a private ghcr repository, not at Docker Hub. Thinking about it, I saw you use https://github.com/estesp/manifest-tool. (Or at least that's what I got from the code, although I honestly haven't written any Go yet.) They say
which reminded me there is https://github.com/docker/login-action that probably quite a few people already use. I honestly do not know how, but I think it'd be elegant to leverage that action. I'd assume that in most scenarios the base image to compare to is public anyway, or at least the base image and the one that builds on it are in the same private container registry. That would allow to write something along the lines of - uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- uses: someone/docker-image-update-checker@v1
with:
base-image: library/alpine:latest
my-image: ghcr.io/me/my-private-image What do you think? 🤔 |
can we discuss the in the same repo for others benefit? |
I saw your custom action is a docker image. Holy moly, I didn't know that was possible! 😮 That lets us use |
of course you can use, but didn't wanted to invest lot of time on this and just wanted something real quick so I used what I used before :) and wrt to auth, yon use something like below and works: - uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- uses: mkumatag/container-image-updater-action@v1.0.5
with:
base-image: 'library/alpine:latest'
image: 'ghcr.io/me/my-private-image'
image-reg-username: ${{ github.actor }}
image-reg-password: ${{ secrets.GITHUB_TOKEN }} |
I have forked this repo to try and solve this issue (and some others like multi arch and support Windows). I am testing it right now. I am testing it with mcr.microsoft.com and Windows Containers. It is at https://github.com/giggio/docker-image-update-checker @lucacome Your code was a good start, I could send you a PR so we keep only yours at the marketplace, but I'm not sure if you agree with the design decisions I made, it is fine if you want to keep them separate. Thanks for the project, it was able to solve the issue I was having and it is good Github Action. Here is a test run on a real container I maintain: https://github.com/Lambda3/notifypasswordexpiration/actions/runs/1851393079 |
@giggio You might want to check out I'm still waiting for the maintainers of |
Using |
Ah, I didn't know that. Best of luck. 🤞 |
Rightnow code is more tied with docker hub but there are other registries like quay, gcr, wondering if we can enhance the code to support all the remaining registries.
The text was updated successfully, but these errors were encountered: