Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some comments here and there. In general, I would try to break up your file structure a bit. If I read your filenames it is pretty hard to understand how things interact and in most files you have a lot of static functions, so it seems like a file is not something that combines things that have one clear purpose but just a bunch of thrown together functions. Would try to divide by purpose / activity into subfolders like : imageprocessing, io, datastructure or something like that with dedicated files for specific things #6

Open
lucamarini22 opened this issue Mar 31, 2023 · 0 comments

Comments

@lucamarini22
Copy link
Owner

          Some comments here and there. In general, I would try to break up your file structure a bit. If I read your filenames it is pretty hard to understand how things interact and in most files you have a lot of static functions, so it seems like a file is not something that combines things that have one clear purpose but just a bunch of thrown together functions. Would try to divide by purpose / activity into subfolders like : imageprocessing, io, datastructure or something like that with dedicated files for specific things

A few things I point out depend a bit on how much you want this to be code for one project that should be comprehensible, but doesn't have to be reused or built-on later. If the latter then you may want to consider using:

Hope it can help ✌️

Originally posted by @gomezzz in #3 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant