add a metrics package using OpenCensus, trace connections #2646
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2646 +/- ##
=======================================
Coverage 86.68% 86.68%
=======================================
Files 123 123
Lines 9778 9778
=======================================
Hits 8476 8476
Misses 970 970
Partials 332 332 Continue to review full report at Codecov.
|
| ) | ||
| } | ||
|
|
||
| func (t *connTracer) ClosedConnection(logging.CloseReason) {} |
There was a problem hiding this comment.
I know that opencensus doesn't technically have the concept of a gauge but I am pretty sure that you can just do a connection.M(-1). So we should be able to model activeConnections and not just the total number of connections that have been opened since the program started. There may be some issues with this approach if the metrics collector restarts and the process doesn't but I don't think so.
There was a problem hiding this comment.
I'm a bit confused now. I had thought of this counter to be plotted as something like rate(connections[30s]), so it would measure the rate with which we're dialing and accepting new connections. Maybe connections is not the right name then?
If I understand correctly, what you're proposing is an active connection counter. I think I can introduce some counter variables into the tracer, then we don't have to worry about the metrics collector restarting.
Does that make sense to you?
There was a problem hiding this comment.
If you need a gauge, a better way of doing that could be keeping track of opened and closed connections (with the error code) separately. That allows you to implement a gauge as one of multiple possible downstream reports.
| ) | ||
| } | ||
|
|
||
| func (t *connTracer) ClosedConnection(logging.CloseReason) {} |
There was a problem hiding this comment.
If you need a gauge, a better way of doing that could be keeping track of opened and closed connections (with the error code) separately. That allows you to implement a gauge as one of multiple possible downstream reports.
|
|
||
| // Tags | ||
| var ( | ||
| keyPerspective, _ = tag.NewKey("perspective") |
There was a problem hiding this comment.
Not sure about this, but another option here could be encoding server vs client in the counter name:
- /quic/server/connections
- /quic/server/var-that-only-makes-sense-for-servers
- /quic/client/connections
- /quic/client/var-that-only-makes-sense-for-clients
There was a problem hiding this comment.
Let's keep it as is for now. I'm just beginning to explore what we want to export, so this will probably change a couple of times anyway as we define more metrics.
No description provided.