add integration tests using faulty packet conns #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-clemente
approved these changes
Jul 10, 2020
marten-seemann
force-pushed
the
faulty-packet-conn-integration-test
branch
from
0ff71c4
to
1a0b642
Compare
Codecov Report
@@ Coverage Diff @@
## master #2663 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 122 122
Lines 9749 9749
=======================================
Hits 8445 8445
Misses 971 971
Partials 333 333 Continue to review full report at Codecov.
|
|
@marten-seemann oh sorry missed this, I think this is usually the case relatively quickly in practice... I don't think golang technically claims anything about this property of the interface. I can imagine these error-ing at slightly different times due to differences in deadlines or something, but may not be worth the fidgety-ness / buy much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2659. Depends on #2656.
This would have caught #2655. @ltucker, is it realistic to assume that if a connection fails, both
ReadFromandWriteTowill return an error?