move the SupportedVersions slice out of the wire.Header #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
move-versions-out-of-the-header
branch
from
ee342be
to
993d71f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2664 +/- ##
==========================================
- Coverage 86.44% 86.42% -0.02%
==========================================
Files 122 122
Lines 9763 9766 +3
==========================================
+ Hits 8439 8440 +1
- Misses 989 990 +1
- Partials 335 336 +1
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to have this slice in the
wire.Header. We can reduce the memory size of this struct by treating the supported version as "payload" of a Version Negotiation packet, instead of as part of the header. Not only is this more efficient, it's also more consistent with the QUIC draft.