Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify the Tracer interface by combining the TracerFor... methods #2671

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

marten-seemann
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #2671 into master will increase coverage by 0.06%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2671      +/-   ##
==========================================
+ Coverage   86.71%   86.76%   +0.06%     
==========================================
  Files         124      124              
  Lines        9862     9852      -10     
==========================================
- Hits         8551     8548       -3     
+ Misses        975      971       -4     
+ Partials      336      333       -3     
Impacted Files Coverage Δ
server.go 84.57% <0.00%> (+0.89%) ⬆️
client.go 81.67% <100.00%> (ø)
logging/multiplex.go 94.87% <100.00%> (+2.01%) ⬆️
qlog/qlog.go 96.06% <100.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ece3592...ee24d38. Read the comment docs.

@marten-seemann marten-seemann force-pushed the simplify-tracer-interface branch 3 times, most recently from 39b54de to 5c4cdf0 Compare July 11, 2020 06:15
@marten-seemann marten-seemann merged commit 15e1857 into master Jul 12, 2020
@marten-seemann marten-seemann deleted the simplify-tracer-interface branch July 13, 2020 03:45
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants