fix reading of flag values in integration tests #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flag values are not available in init(), and since Go 1.13, it's not possible to call flag.Parse() in init().
Codecov Report
@@ Coverage Diff @@
## master #2690 +/- ##
=======================================
Coverage 86.74% 86.74%
=======================================
Files 124 124
Lines 9905 9905
=======================================
Hits 8592 8592
Misses 980 980
Partials 333 333 Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag values are not available in
init(), and since Go 1.13, it's not possible to callflag.Parse()ininit().