never send a value larger than 2^60 in MAX_STREAMS frames #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
fix-max-streams-frame-overflow
branch
from
cfae51d
to
3c62c48
Compare
Codecov Report
@@ Coverage Diff @@
## master #2710 +/- ##
=======================================
Coverage 86.77% 86.77%
=======================================
Files 124 124
Lines 9893 9894 +1
=======================================
+ Hits 8584 8585 +1
Misses 979 979
Partials 330 330
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Aug 17, 2020
| }) | ||
| maxStream := m.nextStreamToOpen + protocol.StreamNum(m.maxNumStreams-uint64(len(m.streams))) - 1 | ||
| // Never send a value larger than protocol.MaxStreamCount. | ||
| if maxStream <= protocol.MaxStreamCount { |
There was a problem hiding this comment.
In the false case, should we send a capped maxStreamId frame, error, …? Silently ignoring this seems fragile?
There was a problem hiding this comment.
There's no error here. It's just that we're running out of stream IDs (which are limit by the way they're encoded... to 2^60 per stream type).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2709.