regenerate the testdata certificate with SAN instead of CommonName #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
regenerate-cert-with-san
branch
from
4148f5e
to
8f08c10
Compare
|
Well that's not very helpful...
|
Codecov Report
@@ Coverage Diff @@
## master #2723 +/- ##
=======================================
Coverage 86.49% 86.49%
=======================================
Files 126 126
Lines 9952 9952
=======================================
Hits 8607 8607
Misses 1013 1013
Partials 332 332 Continue to review full report at Codecov.
|
As required by Go 1.15.
marten-seemann
force-pushed
the
regenerate-cert-with-san
branch
from
8f08c10
to
154f434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2721. Follow-up to #2720.
As required by Go 1.15.
I also added the script used to generate the certificate, in case we need to regenerate it again at some point in the future. Maybe it's just me, but I don't find the openssl API not really intuitive...