Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable Path MTU Discovery on Windows #3276

Merged
merged 1 commit into from
Oct 13, 2021
Merged

disable Path MTU Discovery on Windows #3276

merged 1 commit into from
Oct 13, 2021

Conversation

marten-seemann
Copy link
Member

Fixes #3273.

@codecov
Copy link

codecov bot commented Sep 14, 2021 •
edited
Loading

Codecov Report

Merging #3276 (d410b59) into master (3b46d74) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3276   +/-   ##
=======================================
  Coverage   85.48%   85.48%           
=======================================
  Files         132      132           
  Lines        9799     9800    +1     
=======================================
+ Hits         8376     8377    +1     
  Misses       1048     1048           
  Partials      375      375
Impacted Files Coverage Δ
conn_windows.go 56.52% <ø> (ø)
session.go 77.65% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b46d74...d410b59. Read the comment docs.

@marten-seemann marten-seemann force-pushed the windows-disable-pmtud branch 3 times, most recently from b0d22d1 to f481387 Compare September 17, 2021 08:25
@marten-seemann marten-seemann merged commit e6572e3 into master Oct 13, 2021
@marten-seemann marten-seemann deleted the windows-disable-pmtud branch October 16, 2021 17:09
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
Closed
80 tasks
@imsodin imsodin mentioned this pull request Dec 28, 2021
Merged
zllovesuki added a commit to zllovesuki/quic-go that referenced this pull request Feb 9, 2022
@zllovesuki
sendQueue: ignore "datagram too large" error
f5b6364 
This commit introduces additional platform-dependent checking when the
kernel returns an error. Previously, the session is terminated when
PingFrame sends a discovery packet larger than the limit. With this
commit, the error is checked, and if it is "datagram too large", the
error is ignored.

Additionally, this commit re-enables MTU discovery on Windows unless it
is disabled explicitly by user.

Undo quic-go#3276
Fixes quic-go#3273 quic-go#3327
@zllovesuki zllovesuki mentioned this pull request Feb 9, 2022
Merged
zllovesuki added a commit to zllovesuki/quic-go that referenced this pull request Feb 9, 2022
@zllovesuki
sendQueue: ignore "datagram too large" error
b255d7d 
This commit introduces additional platform-dependent checking when the
kernel returns an error. Previously, the session is terminated when
PingFrame sends a discovery packet larger than the limit. With this
commit, the error is checked, and if it is "datagram too large", the
error is ignored.

Additionally,
1. This commit re-enables MTU discovery on Windows unless it
is disabled explicitly by user (Undo quic-go#3276),
2. Set IP_DONTFRAGMENT and IPV6_DONTFRAG with error checking on Windows,
   and
3. Set IP_MTU_DISCOVERY to PMTUDISC_DO for both IPv4 and IPv6 on Linux
   so that the kernel will return "message too long".

Fixes quic-go#3273 quic-go#3327
zllovesuki added a commit to zllovesuki/quic-go that referenced this pull request Feb 10, 2022
@zllovesuki
sendQueue: ignore "datagram too large" error
52c5fc3 
This commit introduces additional platform-dependent checking when the
kernel returns an error. Previously, the session is terminated when
PingFrame sends a discovery packet larger than the limit. With this
commit, the error is checked, and if it is "datagram too large", the
error is ignored.

Additionally,
1. This commit re-enables MTU discovery on Windows unless it
is disabled explicitly by user (Undo quic-go#3276),
2. Set IP_DONTFRAGMENT and IPV6_DONTFRAG with error checking on Windows,
   and
3. Set IP_MTU_DISCOVERY to PMTUDISC_DO for both IPv4 and IPv6 on Linux
   so that the kernel will return "message too long".

Fixes quic-go#3273 quic-go#3327
zllovesuki added a commit to zllovesuki/quic-go that referenced this pull request Feb 10, 2022
@zllovesuki
sendQueue: ignore "datagram too large" error
f67b3ee 
This commit introduces additional platform-dependent checking when the
kernel returns an error. Previously, the session is terminated when
PingFrame sends a discovery packet larger than the limit. With this
commit, the error is checked, and if it is "datagram too large", the
error is ignored.

Additionally,
1. This commit re-enables MTU discovery on Windows unless it
is disabled explicitly by user (Undo quic-go#3276),
2. Set IP_DONTFRAGMENT and IPV6_DONTFRAG with error checking on Windows,
   and
3. Set IP_MTU_DISCOVERY to PMTUDISC_DO for both IPv4 and IPv6 on Linux
   so that the kernel will return "message too long".

Fixes quic-go#3273 quic-go#3327
nmldiegues pushed a commit to nmldiegues/quic-go that referenced this pull request Feb 10, 2022
@zllovesuki @nmldiegues
sendQueue: ignore "datagram too large" error
4128148 
This commit introduces additional platform-dependent checking when the
kernel returns an error. Previously, the session is terminated when
PingFrame sends a discovery packet larger than the limit. With this
commit, the error is checked, and if it is "datagram too large", the
error is ignored.

Additionally,
1. This commit re-enables MTU discovery on Windows unless it
is disabled explicitly by user (Undo quic-go#3276),
2. Set IP_DONTFRAGMENT and IPV6_DONTFRAG with error checking on Windows,
   and
3. Set IP_MTU_DISCOVERY to PMTUDISC_DO for both IPv4 and IPv6 on Linux
   so that the kernel will return "message too long".

Fixes quic-go#3273 quic-go#3327
marten-seemann pushed a commit that referenced this pull request Feb 20, 2022
@zllovesuki
sendQueue: ignore "datagram too large" error (#3328)
fd2c345 
This commit introduces additional platform-dependent checking when the
kernel returns an error. Previously, the session is terminated when
PingFrame sends a discovery packet larger than the limit. With this
commit, the error is checked, and if it is "datagram too large", the
error is ignored.

Additionally,
1. This commit re-enables MTU discovery on Windows unless it
is disabled explicitly by user (Undo #3276),
2. Set IP_DONTFRAGMENT and IPV6_DONTFRAG with error checking on Windows,
   and
3. Set IP_MTU_DISCOVERY to PMTUDISC_DO for both IPv4 and IPv6 on Linux
   so that the kernel will return "message too long".

Fixes #3273 #3327
nmldiegues pushed a commit to chungthuang/quic-go that referenced this pull request Jun 6, 2022
@zllovesuki @nmldiegues
sendQueue: ignore "datagram too large" error (quic-go#3328)
9d3b60f 
This commit introduces additional platform-dependent checking when the
kernel returns an error. Previously, the session is terminated when
PingFrame sends a discovery packet larger than the limit. With this
commit, the error is checked, and if it is "datagram too large", the
error is ignored.

Additionally,
1. This commit re-enables MTU discovery on Windows unless it
is disabled explicitly by user (Undo quic-go#3276),
2. Set IP_DONTFRAGMENT and IPV6_DONTFRAG with error checking on Windows,
   and
3. Set IP_MTU_DISCOVERY to PMTUDISC_DO for both IPv4 and IPv6 on Linux
   so that the kernel will return "message too long".

Fixes quic-go#3273 quic-go#3327
@mochaaP mochaaP mentioned this pull request May 3, 2023
Closed
This was referenced Nov 1, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-clemente lucas-clemente lucas-clemente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mtu_discoverer: INTERNAL_ERROR on Windows
2 participants
@marten-seemann @lucas-clemente