Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing of request path for Extended CONNECT requests #3388

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

marten-seemann
Copy link
Member

In order to extract request parameters from Extended CONNECT, we need to call url.ParseRequestURI.

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #3388 (889051d) into master (6d4a694) will decrease coverage by 0.01%.
The diff coverage is 86.67%.

@@            Coverage Diff             @@
##           master    #3388      +/-   ##
==========================================
- Coverage   85.39%   85.38%   -0.01%     
==========================================
  Files         135      135              
  Lines        9906     9913       +7     
==========================================
+ Hits         8459     8464       +5     
- Misses       1065     1066       +1     
- Partials      382      383       +1     
Impacted Files Coverage Δ
http3/request.go 91.55% <86.67%> (-2.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4a694...889051d. Read the comment docs.

@marten-seemann marten-seemann merged commit 5dedb7e into master Apr 25, 2022
nmldiegues pushed a commit to chungthuang/quic-go that referenced this pull request Jun 6, 2022
@MarcoPolo MarcoPolo mentioned this pull request Jul 7, 2022
41 tasks
sudarshan-reddy pushed a commit to sudarshan-reddy/quic-go that referenced this pull request Aug 9, 2022
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
@marten-seemann marten-seemann deleted the fix-extended-connect-path-parsing branch July 23, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants