-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clone TLS conf in newClient #3400
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @betamos!
Can you please sign the CLA? Then we can merge the PR.
Codecov Report
@@ Coverage Diff @@
## master #3400 +/- ##
==========================================
- Coverage 85.36% 85.36% -0.01%
==========================================
Files 135 135
Lines 9928 9930 +2
==========================================
+ Hits 8475 8476 +1
Misses 1068 1068
- Partials 385 386 +1
Continue to review full report at Codecov.
|
I did earlier today. Verified that email matches commit and username is correct. Is it possible to re-run the workflow? Otherwise, I don't know what could be the issue. |
@lucas-clemente Can you please check? Looks like the CLA bot is misbehaving (again). |
I was able to retrigger the CLA check myself, there was a link at the bottom that I missed the first time around. Good to go now :) |
Fixes #3394
-race
in case you're not already doing that. Or let me know if you already a unit test approach in mind.Obligatory thanks for maintaining this amazing library.