pass frame / stream type parsing errors to the hijacker callbacks

[marten-seemann]

When a stream is reset, we might not have received the frame / stream type yet. The callback might be able to identify if it was a stream intended for that application by analyzing the stream reset error.

This will allow us to resolve marten-seemann/go-libp2p-webtransport#3. The WebTransport implementation can determine if the stream reset error code is in the WebTransport error code range.

@ydnar @hareku Thoughts?

[codecov]

Codecov Report

Merging #3429 (96c0dac) into master (3088865) will increase coverage by 0.01%.
The diff coverage is 90.91%.

@@            Coverage Diff             @@
##           master    #3429      +/-   ##
==========================================
+ Coverage   85.66%   85.67%   +0.01%     
==========================================
  Files         136      136              
  Lines        9948     9957       +9     
==========================================
+ Hits         8521     8530       +9     
- Misses       1049     1050       +1     
+ Partials      378      377       -1     

Impacted Files	Coverage Δ
http3/roundtrip.go	93.55% <ø> (ø)
http3/frames.go	84.62% <71.43%> (-1.69%)	⬇️
http3/client.go	90.91% <100.00%> (+0.64%)	⬆️
http3/server.go	74.45% <100.00%> (+0.48%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3088865...96c0dac. Read the comment docs.

[MarcoPolo]

Granted, I'm not familiar with this codebase, this change seems relatively straightforward and it makes sense that a hijacker would have more context than the general library.

One question not specific to this PR but in general is that it seems like there are UniStreamHijacker tests but no matching StreamHijacker tests. Any specific reason?

[hareku]

One question not specific to this PR but in general is that it seems like there are UniStreamHijacker tests but no matching StreamHijacker tests. Any specific reason?

Please use #3391 if you like.

[marten-seemann]

@hareku Thank you. I had actually missed your PR. I've merged it now, and rebased this PR.

@MarcoPolo Thanks for pointing this is out in the review. This actually helped uncover a bug, which I fixed in 5cb2e82.