Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement QUIC v2 #3432

Merged
merged 6 commits into from
Jun 9, 2022
Merged

implement QUIC v2 #3432

merged 6 commits into from
Jun 9, 2022

Conversation

marten-seemann
Copy link
Member

Fixes #3412.

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #3432 (c5ee496) into master (8185d1b) will decrease coverage by 0.02%.
The diff coverage is 89.69%.

@@            Coverage Diff             @@
##           master    #3432      +/-   ##
==========================================
- Coverage   85.44%   85.42%   -0.02%     
==========================================
  Files         136      136              
  Lines        9946     9989      +43     
==========================================
+ Hits         8498     8533      +35     
- Misses       1066     1074       +8     
  Partials      382      382              
Impacted Files Coverage Δ
internal/wire/header.go 86.96% <76.00%> (-3.37%) ⬇️
internal/wire/extended_header.go 87.14% <80.00%> (-0.45%) ⬇️
http3/server.go 72.61% <100.00%> (-0.09%) ⬇️
internal/handshake/aead.go 98.11% <100.00%> (+0.20%) ⬆️
internal/handshake/crypto_setup.go 66.82% <100.00%> (ø)
internal/handshake/header_protector.go 80.00% <100.00%> (+1.74%) ⬆️
internal/handshake/initial_aead.go 100.00% <100.00%> (ø)
internal/handshake/updatable_aead.go 96.45% <100.00%> (+0.03%) ⬆️
internal/protocol/version.go 94.59% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8185d1b...c5ee496. Read the comment docs.

@marten-seemann marten-seemann merged commit 619fa9f into master Jun 9, 2022
@marten-seemann marten-seemann deleted the quicv2 branch June 9, 2022 15:40
@mattrobenolt
Copy link
Contributor

I'm guessing this is minor, but after this change, we get duplicate values in the Alt-Svc header due to generateAltSvcHeader() spitting back duplicate h3 values because of Version1 and Version2 both being coalesced to h3.

As a concrete example:

alt-svc: h3=":8080"; ma=2592000,h3=":8080"; ma=2592000,h3-29=":8080"; ma=2592000

is what I'm getting now, notice how there are two identical h3 values.

I'm happy to submit a PR for this.

@MarcoPolo MarcoPolo mentioned this pull request Jul 7, 2022
41 tasks
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement QUIC v2
3 participants