Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "HTTP/3" to "HTTP/3.0". #3439

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

aaronriekenberg
Copy link
Contributor

@aaronriekenberg aaronriekenberg commented May 31, 2022

See caddyserver/caddy#4819 for context.

go's http.ParseHTTPVersion is unable to parse HTTP/3. This causes issues when using caddy as a reverse proxy to a go fastcgi server using net/http/fcgi.

Found instances of "HTTP/3" to change using grep:

grep -r '"HTTP/3"' *

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #3439 (fffd414) into master (b5ef99a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3439   +/-   ##
=======================================
  Coverage   85.69%   85.69%           
=======================================
  Files         135      135           
  Lines        9955     9955           
=======================================
  Hits         8530     8530           
  Misses       1048     1048           
  Partials      377      377           
Impacted Files Coverage Δ
http3/client.go 90.91% <100.00%> (ø)
http3/request.go 91.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ef99a...fffd414. Read the comment docs.

Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marten-seemann marten-seemann merged commit 990b1fe into quic-go:master Jun 2, 2022
nmldiegues pushed a commit to chungthuang/quic-go that referenced this pull request Jun 6, 2022
@mholt
Copy link
Contributor

mholt commented Jun 20, 2022

Very nice, thanks! When should we update Caddy to get this patch?

@marten-seemann
Copy link
Member

@mholt Sorry for the late reply. We'll be releasing a new minor version (v0.28.0) in the next couple of days.

@mholt
Copy link
Contributor

mholt commented Jun 25, 2022

No worries, and that's great, thanks!

@MarcoPolo MarcoPolo mentioned this pull request Jul 7, 2022
41 tasks
sudarshan-reddy pushed a commit to sudarshan-reddy/quic-go that referenced this pull request Aug 9, 2022
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants