Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only set DF for sockets that can handle it #3448

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

nmldiegues
Copy link
Contributor

Fixes #3445

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #3448 (72b878c) into master (6fbc6d9) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #3448   +/-   ##
=======================================
  Coverage   85.69%   85.69%           
=======================================
  Files         136      136           
  Lines        9993     9994    +1     
=======================================
+ Hits         8563     8564    +1     
  Misses       1054     1054           
  Partials      376      376           
Impacted Files Coverage Δ
sys_conn.go 85.19% <50.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fbc6d9...72b878c. Read the comment docs.

Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marten-seemann marten-seemann changed the title Only set DF for sockets that can handle that only set DF for sockets that can handle that Jun 19, 2022
@marten-seemann marten-seemann changed the title only set DF for sockets that can handle that only set DF for sockets that can handle it Jun 19, 2022
@marten-seemann marten-seemann merged commit 706a482 into quic-go:master Jun 19, 2022
@MarcoPolo MarcoPolo mentioned this pull request Jul 7, 2022
41 tasks
sudarshan-reddy pushed a commit to sudarshan-reddy/quic-go that referenced this pull request Aug 9, 2022
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setsockopt fails to set IP_MTU_DISCOVER in SOCK_SEQPACKET
2 participants