dedupe Alt-Svc header values #3461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3461 +/- ##
=======================================
Coverage 85.69% 85.70%
=======================================
Files 136 136
Lines 9994 9997 +3
=======================================
+ Hits 8564 8567 +3
Misses 1054 1054
Partials 376 376
Continue to review full report at Codecov.
|
|
Could you also add a test case for this please? |
|
@mattrobenolt We're planning to cut a new quic-go release really soon. Would be great if we could get your patch in. Will you be able to incorporate the comments? |
|
Yeah, lemme take a stab today. I'm not familiar with the test suite, so that might be my only hangup. |
mattrobenolt
force-pushed
the
duplicate-alt-svc
branch
from
409493a
to
e78d81d
Compare
|
@marten-seemann test added, should be good to go. |
mattrobenolt
force-pushed
the
duplicate-alt-svc
branch
from
e78d81d
to
1a7072f
Compare
marten-seemann
changed the title
41 tasks
sudarshan-reddy
pushed a commit
to sudarshan-reddy/quic-go
that referenced
this pull request
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3432 (comment)