fix usage of ackhandler.Packet pool for non-ack-eliciting packets #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
commented
Aug 30, 2022
| @@ -27,31 +27,37 @@ func newSentPacketHistory(rttStats *utils.RTTStats) *sentPacketHistory { | |||
| } | |||
| } | |||
|
|
|||
| func (h *sentPacketHistory) SentPacket(p *Packet, isAckEliciting bool) { | |||
| if p.PacketNumber <= h.highestSent { | |||
| func (h *sentPacketHistory) SentNonAckElicitingPacket(pn protocol.PacketNumber, encLevel protocol.EncryptionLevel, t time.Time) { | |||
There was a problem hiding this comment.
This function now takes the values directly and not a *Packet, to sure there's no way it can store the *Packet.
Codecov ReportBase: 85.56% // Head: 85.49% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3538 +/- ##
==========================================
- Coverage 85.56% 85.49% -0.07%
==========================================
Files 137 137
Lines 10087 10259 +172
==========================================
+ Hits 8630 8770 +140
- Misses 1080 1109 +29
- Partials 377 380 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lucas-clemente
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3537.