Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ackhandler: reject duplicate packets in ReceivedPacket #3568

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

marten-seemann
Copy link
Member

Before we process a packet, IsPotentiallyDuplicate is called. This should filter out all duplicates before the reach ReceivedPacket.

This is probably a better fix than #3566. Closes #3566.

Before we process a packet, IsPotentiallyDuplicate is called.
This should filter out all duplicates before the reach ReceivedPacket.
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 85.50% // Head: 85.47% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (a178ad6) compared to base (424a663).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3568      +/-   ##
==========================================
- Coverage   85.50%   85.47%   -0.04%     
==========================================
  Files         139      139              
  Lines       10244    10246       +2     
==========================================
- Hits         8759     8757       -2     
- Misses       1103     1105       +2     
- Partials      382      384       +2     
Impacted Files Coverage Δ
internal/ackhandler/received_packet_handler.go 73.13% <66.67%> (-2.62%) ⬇️
internal/ackhandler/received_packet_tracker.go 84.09% <100.00%> (-2.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marten-seemann marten-seemann merged commit 438942b into master Oct 11, 2022
@marten-seemann marten-seemann deleted the reject-old-packets-received-packet branch October 11, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants