expose function to convert byte slice to a connection ID

[hf]

Although quic.Config exposes a ConnectionIDGenerator option, it's not usable outside of the quic-go implementation because type ConnectionID = protocol.ConnectionID and protocol is an internal package not accessible from the outside.

To fix this, the ReadConnectionID and ParseConnectionID methods from protocol are re-exported in the toplevel package.

[marten-seemann]

What is ReadConnectionID needed for?

ParseConnectionID should probably also have better name. Maybe ConnectionIDFromBytes?

[hf]

What is ReadConnectionID needed for?

I'm just re-exporting the methods from protocol. If it were up to me, that whole logic wouldn't live inside internal but that's what it is.

I am working on some experiments where I need greater control over connection IDs -- such as picking a different randomness generator (not crypto/rand).

ParseConnectionID should probably also have better name. Maybe ConnectionIDFromBytes?

Sure, tho I'd like to keep it similar to whatever is in protocol.

[marten-seemann]

I am working on some experiments where I need greater control over connection IDs -- such as picking a different randomness generator (not crypto/rand).

Sure, that's what the ConnectionIDGenerator is there for. I still don't think we need both methods - just trying to keep the publicly exposed API clean (that's what internal is pretty good at ;))

ParseConnectionID should probably also have better name. Maybe ConnectionIDFromBytes?

Sure, tho I'd like to keep it similar to whatever is in protocol.

It's not really doing any parsing. Really, it's just converting from a byte slice, hence my suggestion.

[marten-seemann]

@hf Are you planning to make these changes?

[hf]

@hf Are you planning to make these changes?

Hey, yes I am but probably this weekend.

[hf]

@marten-seemann Done!

[codecov]

Codecov Report

Base: 85.48% // Head: 85.49% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (962204c) compared to base (df762b7).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3614      +/-   ##
==========================================
+ Coverage   85.48%   85.49%   +0.01%     
==========================================
  Files         141      142       +1     
  Lines       10296    10294       -2     
==========================================
- Hits         8801     8800       -1     
  Misses       1109     1109              
+ Partials      386      385       -1     

Impacted Files	Coverage Δ
interface.go	0.00% <0.00%> (ø)
client.go	80.00% <0.00%> (+1.09%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[marten-seemann]

Thank you!