Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default logger #211

Merged
merged 3 commits into from
May 6, 2019
Merged

Add default logger #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e447ef
Add default logger
May 6, 2019
8af5e99
Update project
May 6, 2019
8a6b3eb
Fix
May 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SwiftQueue/JobBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public final class JobBuilder {
return self
}

internal func build(job: Job, logger: SwiftQueueLogger) -> SqOperation {
internal func build(job: Job, logger: SwiftQueueLogger = NoLogger.shared) -> SqOperation {
return SqOperation(job: job, info: info, logger: logger)
}

Expand Down
4 changes: 0 additions & 4 deletions SwiftQueue.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
D0B7CD1E797A69C89CB0ADE2 /* SqOperationQueue.swift in Sources */ = {isa = PBXBuildFile; fileRef = D0B7CB571CECEEA34DD07398 /* SqOperationQueue.swift */; };
D0B7CE62CE9A0DB7DF08FB57 /* ConstraintUniqueUUIDTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = D0B7C37E250DEE9A9B55C8ED /* ConstraintUniqueUUIDTests.swift */; };
D0B7CFA2089DFF576E0D765B /* JobBuilder.swift in Sources */ = {isa = PBXBuildFile; fileRef = D0B7CB3B79E039D3B11D8921 /* JobBuilder.swift */; };
OBJ_27 /* SwiftQueueTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = OBJ_11 /* SwiftQueueTests.swift */; };
OBJ_29 /* SwiftQueue.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = OBJ_13 /* SwiftQueue.framework */; };
/* End PBXBuildFile section */

Expand Down Expand Up @@ -132,7 +131,6 @@
D0B7C898344F1EB3A0815D67 /* ConstraintDeadlineTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ConstraintDeadlineTests.swift; sourceTree = "<group>"; };
D0B7CB3B79E039D3B11D8921 /* JobBuilder.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = JobBuilder.swift; path = SwiftQueue/JobBuilder.swift; sourceTree = "<group>"; };
D0B7CB571CECEEA34DD07398 /* SqOperationQueue.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = SqOperationQueue.swift; path = SwiftQueue/SqOperationQueue.swift; sourceTree = "<group>"; };
OBJ_11 /* SwiftQueueTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SwiftQueueTests.swift; sourceTree = "<group>"; };
OBJ_13 /* SwiftQueue.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; path = SwiftQueue.framework; sourceTree = BUILT_PRODUCTS_DIR; };
OBJ_14 /* SwiftQueueTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; path = SwiftQueueTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
/* End PBXFileReference section */
Expand Down Expand Up @@ -192,7 +190,6 @@
1D7B3D2E1F5C1EC7000D49B6 /* ConstraintTests.swift */,
1D7B3D2F1F5C1EC7000D49B6 /* StartStopTests.swift */,
1D7B3D311F5C1EC7000D49B6 /* TestUtils.swift */,
OBJ_11 /* SwiftQueueTests.swift */,
D0B7C37E250DEE9A9B55C8ED /* ConstraintUniqueUUIDTests.swift */,
D0B7C812F675CD459799C2DD /* ConstraintNetworkTests.swift */,
D0B7C62E5894FA6EE00D3160 /* PersisterTests.swift */,
Expand Down Expand Up @@ -492,7 +489,6 @@
buildActionMask = 0;
files = (
1D7B3D361F5C1EDC000D49B6 /* StartStopTests.swift in Sources */,
OBJ_27 /* SwiftQueueTests.swift in Sources */,
1D7B3D391F5C1EE4000D49B6 /* TestUtils.swift in Sources */,
1D7B3D371F5C1EDE000D49B6 /* ConstraintTests.swift in Sources */,
D0B7C94CAD20ADBB67BE5192 /* SwiftQueueBuilderTests.swift in Sources */,
Expand Down
2 changes: 1 addition & 1 deletion Tests/SwiftQueueTests/SwiftQueueManagerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class SwiftQueueManagerTests: XCTestCase {
}

func testAddOperationNotJobTask() {
let queue = SqOperationQueue(id: UUID().uuidString)
let queue = SqOperationQueue(UUID().uuidString, TestCreator([:]), UserDefaultsPersister(), DecodableSerializer(), false, true, NoLogger.shared)
let operation = Operation()
queue.addOperation(operation) // Should not crash
}
Expand Down
37 changes: 0 additions & 37 deletions Tests/SwiftQueueTests/SwiftQueueTests.swift
View file
Open in desktop

This file was deleted.