Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: DistanceCIE76 underdocumented #40

Closed
dolmen opened this issue Feb 11, 2020 · 4 comments
Closed

doc: DistanceCIE76 underdocumented #40

dolmen opened this issue Feb 11, 2020 · 4 comments

Comments

@dolmen
Copy link

dolmen commented Feb 11, 2020

The documentation for DistanceCIE76 says:

That's actually the same, but I don't want to break code.

Same as what?

@ErnestoBorio
Copy link

ErnestoBorio commented Feb 11, 2020

As you can see in the code, it's the same that the function immediately before: (DistanceLab)
https://github.com/lucasb-eyer/go-colorful/blob/v1.0.3/colors.go#L594

@dolmen
Copy link
Author

dolmen commented Apr 14, 2020

@ErnestoBorio My point is that should be written in the doc itself.

@KelSolaar
Copy link

Looking at the doc:

// DistanceLab is a good measure of visual similarity between two colors!

This is not quite true, simple Euclidean distance in CIE Lab space IS NOT a good measure because perceptual uniformity of CIE Lab is not great. It the main reason why the CIE introduced the CIE 1994 and CIE 2000 quasi-metrics.

@makew0rld
Copy link
Collaborator

makew0rld commented Jan 28, 2021

@dolmen This is properly documented now.

@KelSolaar What would you suggest be written for DistanceLab instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants