Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for HSLuv #41

Closed
muesli opened this issue Mar 12, 2020 · 4 comments · Fixed by #51
Closed

Support for HSLuv #41

muesli opened this issue Mar 12, 2020 · 4 comments · Fixed by #51

Comments

@muesli
Copy link
Contributor

muesli commented Mar 12, 2020

See: https://www.kuon.ch/post/2020-03-08-hsluv/
@makew0rld
Copy link
Collaborator

The official HSLuv website is here.

Converting to HSLuv is already implemented in Go at github.com/hsluv/hsluv-go. Of course it would still be nice to have this implemented here. That library even uses RGB values between 0 and 1 already, so the code could just be copied for the most part.

@makew0rld
Copy link
Collaborator

makew0rld commented Jan 8, 2021 •
edited
Loading

The README mentions

While this seems all good, you need to know one thing: When interpolating in any of the CIE color spaces, you might get invalid RGB colors!

HSLuv fixes this, see here.

This was referenced Jan 21, 2021
Open
Merged
@makew0rld
Copy link
Collaborator

I have added HSLuv support in #51.

cc @muesli

@muesli
Copy link
Contributor Author

muesli commented Jan 28, 2021

Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HSLuv
2 participants
@muesli @makew0rld