Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the environments ever reset for DQN? #31

Open
eleninisioti opened this issue Oct 27, 2024 · 1 comment
Open

Are the environments ever reset for DQN? #31

eleninisioti opened this issue Oct 27, 2024 · 1 comment

Comments

@eleninisioti
Copy link

Hi! First I'd like to give my congrats for this project, I find the implementation of DQNs very clean.

Looking around I see something that could be a bug: the environment is reset at the beginning of training and then I don't see it being reset again. For gymnax environments like Cartpole the 'done' part of the state indicates that the environment needs to be reset. For brax environments this is taken care by the AutoResetWrapper but in most cases you need to reset. Am I missing something?

@harwiltz
Copy link

This raised an alarm for me as well, but I checked and indeed the gymnax environments all do auto-reset. See https://github.com/RobertTLange/gymnax/blob/aef77d5c642ea48b95f34c51d05b8417d9450e15/gymnax/environments/environment.py#L48-L51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants