Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure package to improve maintainability and extensibility #18

Closed
lucianopaz opened this issue Jun 29, 2020 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@lucianopaz
Copy link
Owner

compress_pickle started out small, as a single function script that only provided the dump and load functions. I've expanded the functionality a bit and split the package up into different modules but underlying paradigm has always been functional. I feel that the package is now reaching a point where extending it has become hard, without introducing multiple if statement branches and spaghetti code. In particular, #16 will be a bit ugly to get through with the current structure.

For the moment, I don't have the time to restructure the code into a object oriented implementation, which would be easier to maintain and also to extend, so it's likely that I'll first spin out a small patch to close #16, but it would be really nice in the long run, to aim for an OO structure of compress_pickle.

@lucianopaz lucianopaz added the enhancement New feature or request label Jun 29, 2020
@lucianopaz lucianopaz changed the title Restructure package to improve maintainability and extensivility Restructure package to improve maintainability and extensibility Jun 30, 2020
@lucianopaz
Copy link
Owner Author

Closed by #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant