-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icons): changed book-dashed
icon
#2399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added or changed iconsIcons as codeWorks for: const BookDashedIcon = createLucideIcon('BookDashed', [
["path",{"d":"M12 17h1.5"}],
["path",{"d":"M12 22h1.5"}],
["path",{"d":"M12 2h1.5"}],
["path",{"d":"M17.5 22H19a1 1 0 0 0 1-1"}],
["path",{"d":"M17.5 2H19a1 1 0 0 1 1 1v1.5"}],
["path",{"d":"M20 14v3h-2.5"}],
["path",{"d":"M20 8.5V10"}],
["path",{"d":"M4 10V8.5"}],
["path",{"d":"M4 19.5V14"}],
["path",{"d":"M4 4.5A2.5 2.5 0 0 1 6.5 2H8"}],
["path",{"d":"M8 22H6.5a1 1 0 0 1 0-5H8"}]
]) |
Since this isn't the same size, I'd prefer pixel perfection over uniformity. |
The upside here is also that it's more symmetrical. |
This would be pixel perfect and symetrical. |
ericfennis
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
Changed dash length to be similar to
square-dashed
.The dashes are also no on the same level on each side.
Before Submitting