Skip to content
This repository has been archived by the owner on May 31, 2022. It is now read-only.

Should this library be merged into Avram? #13

Closed
matthewmcgarvey opened this issue Dec 28, 2021 · 1 comment · Fixed by luckyframework/avram#786
Closed

Should this library be merged into Avram? #13

matthewmcgarvey opened this issue Dec 28, 2021 · 1 comment · Fixed by luckyframework/avram#786

Comments

@matthewmcgarvey
Copy link
Member

It's just one file and doesn't provide a lot of functionality. Tried looking in the git commit history and the gitter room for some history on this decision but found nothing.

What if we moved this into Avram? So AvramSlugify would become Avram::Slugify, and we could make an alias for backwards compatibility.
@jwoertink
Copy link
Member

wow... it was only added last year? 🤯 I'm sure Paul and I talked about it, but I can't remember. It felt like a few years ago. I think it would be fine. I can't see any reason why it would be better to be separated.

@jwoertink jwoertink mentioned this issue Jan 11, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrating AvramSlugify luckyframework/avram
2 participants
@jwoertink @matthewmcgarvey